Open
Conversation
Collaborator
|
Why can't confirm be used? |
Author
|
I tried, but it appeared to me that all ways to use Confirm present the user with some kind of choice. There is always the This can be done with Confirm and setting a default, but having the 'y/n' suggests that there is a choice if there actually is none. |
pksunkara
requested changes
Oct 28, 2023
Collaborator
pksunkara
left a comment
pksunkara
left a comment
There was a problem hiding this comment.
Instead of adding a new prompt, can you please modify the confirm prompt with an extra option?
Author
|
Sure. But I wonder if that would introduce a lot of "if-clauses" into the code making it more complex than needed. Right now I think a new prompt has these advantages:
Probably it is just a mattter of coding style, what do you think? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In case of an unexpected events, I would love to display a warning to the user, which simply needs to be "confirmed" for the programm to move on.
The workaround I use is a selection with "OK" as single option, but this is a bit hacky.
I kindly request to add alert as a new interaction option to dialoguer. One can use the pull request, but I probably messed the return types up ...
obsoletes #287